Repository navigation
Conversation
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a small, self-contained web timeline fix that derives live thread titles from existing shell state, updates accessible labels, and links settled rows without changing server behavior or schemas. An unresolved Medium finding still flags incorrect linking for archived or deleted threads and should be addressed separately. Not approved because:
Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
a419382 to
f2bdd9f
Compare
1fcdb1c to
d9b7330
Compare
Dismissing prior approval to re-evaluate 2332b93
060756d to
d6dcd10
Compare
2332b93 to
235ede3
Compare
d2675dc to
9cbaf77
Compare
235ede3 to
48b64e2
Compare
Dismissing prior approval to re-evaluate 48b64e2
6ca6a24 to
3e4ca4c
Compare
48b64e2 to
6bdfff1
Compare
1bd44f2 to
3b9c885
Compare
6bdfff1 to
8eeb330
Compare
This comment has been minimized.
This comment has been minimized.
Dismissing prior approval to re-evaluate b15da98
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
6448cfe to
1563a64
Compare
b15da98 to
51614af
Compare
fe4f6ad to
87c67bd
Compare
51614af to
401dc23
Compare
|
Note This comment is posted by Julius' dot The supplied screenshots show the renamed labels, but not the title-link and row-expansion interaction. Could you add a short recording showing the target opening, the rest of the row expanding, and a rename reaching the same row, plus a before screenshot? This would complete the UI verification evidence while preserving Julius' inline-label rewrite. |
juliusmarminge
added
the
triage:keep-open
Dismissing prior approval to re-evaluate 58d86fe
|
Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies. |
Replay the contribution onto current main and resolve integration changes. Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: PR Batch Tester <agent@local.test>
58d86fe to
098baaf
Compare
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 42 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Comment |
| const { workEntry, workspaceRoot, displayLabel } = props; | ||
| const ctx = use(TimelineRowCtx); | ||
| const { threadRef, onImageExpand, timestampFormat } = ctx; | ||
| const threadTarget = useThreadReadTarget(workEntry, ctx.activeThreadEnvironmentId); |
There was a problem hiding this comment.
🟡 Medium chat/MessagesTimeline.tsx:4998
Archived or deleted threads are rendered with their shell title as a linked ThreadReadLabel, and clicking a deleted thread navigates to the deleted-thread route. useThreadReadTarget must only return a target when shell.archivedAt === null && shell.deletedAt === null; otherwise this row should retain its generic non-link label.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/web/src/components/chat/MessagesTimeline.tsx around line 4998:
Archived or deleted threads are rendered with their shell title as a linked `ThreadReadLabel`, and clicking a deleted thread navigates to the deleted-thread route. `useThreadReadTarget` must only return a target when `shell.archivedAt === null && shell.deletedAt === null`; otherwise this row should retain its generic non-link label.
This branch has not been deployed
2 participants
What Changed
“Read a T3 thread” activity now names the thread it read, on one line:
Read thread “Review auth flow”, in the tool’s tense (Reading / Read / Failed to read). On finished rows the title links to that thread; clicking anywhere else on the row still expands the tool call. The title comes from client shell state, so a rename shows up without a DB join. If the thread is unknown, archived or deleted, the row keeps the generic “Read a T3 thread” label and no link.Why
The tool label alone does not identify the target thread.
UI Changes
Finished row. The title links to the thread; an unknown thread keeps the generic label:
After renaming the target thread, the same row shows the new name:
While the call runs, the live row reads in the present tense:
Verification
Focused MessagesTimeline tests (204), web typecheck, and scoped lint and format checks passed. In an isolated dev app with real Codex
t3_thread_readcalls, the title opened the target thread, followed a rename, and clicking the rest of the row still expanded it. All latest CI checks passed.Checklist
Model: GPT-6 Codex (native Codex harness). Single-line redesign by Claude Opus 5.5 (Claude Code).